Skip to content

Conversation

@yetanothertw
Copy link
Contributor

@yetanothertw yetanothertw commented Oct 24, 2025

Fixes #3285 to clarify that the scope of the tutorial refers to Elastic Agent data streams that use built-in ILM policies.

Fixes #3285 to clarify that the scope of the tutorial refers to Elastic Agent data streams that use built-in ILM policies.
@yetanothertw yetanothertw marked this pull request as ready for review October 24, 2025 15:44
@yetanothertw yetanothertw requested a review from a team as a code owner October 24, 2025 15:44
@yetanothertw yetanothertw requested a review from kilfoyle October 24, 2025 15:44
@yetanothertw yetanothertw self-assigned this Oct 24, 2025
@yetanothertw yetanothertw added documentation Improvements or additions to documentation Team:Admin Issues owned by the Admin Docs Team labels Oct 24, 2025
---

# Customize built-in policies
# Customize built-in {{ilm-init}} policies for {{agent}} data streams
Copy link
Collaborator

@shainaraskas shainaraskas Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stated scope conflicts a little with some of the xrefs. this one just says agent data streams, but we also have the following scopes indicated on the other pages you edited:

  • {{beats}}, {{agent}}, or for the {{agent}} or {{ls}} {{es}} output plugin managed data streams
  • Elastic integration managed data streams

maybe this should become managed data streams and the fleet info on this page might pivot to a "for example" framing

accuracy on all of this I'm not certain on - just looking at signals I'm seeing within this doc :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth doing a dive to find the context in which those two contexts were added to clarify

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Seems like the title describes well the use case in the tutorial, but doesn't account for use cases mentioned in the topics that link to it.

I'll find someone to validate this with and make some changes.

@yetanothertw yetanothertw requested a review from rseldner October 28, 2025 15:26
@yetanothertw
Copy link
Contributor Author

Hi @rseldner -- as discussed on Slack, I've changed the title of the Customize built-in policies to Customize duplicates of built-in ILM policies -- to avoid implying that we're modifying built-in policies, which goes against best practice advice.

I've also made a few small changes in the topics that link to this tutorial, to better clarify the scope of the tutorial.

Please let me know if you think that works. Many thanks in advance! 🙏

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌵
Just one small suggestion.

Copy link
Contributor

@rseldner rseldner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Should we add a note at the end of tutorial-customize-built-in-policies.md that the changes will apply to the new indices and a rollover can optionally be triggered to begin using immediately?

@yetanothertw
Copy link
Contributor Author

Thanks, Roberto!

Should we add a note at the end of tutorial-customize-built-in-policies.md that the changes will apply to the new indices and a rollover can optionally be triggered to begin using immediately?

That's a great shout! I've added that in a new commit.

@yetanothertw yetanothertw merged commit c1617f0 into main Nov 4, 2025
7 checks passed
@yetanothertw yetanothertw deleted the 3285-agent-policy branch November 4, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Team:Admin Issues owned by the Admin Docs Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate scope of ilm customize built in policies tutorial

5 participants