-
Notifications
You must be signed in to change notification settings - Fork 172
Update title for the built-in ILM policies customization topic #3647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #3285 to clarify that the scope of the tutorial refers to Elastic Agent data streams that use built-in ILM policies.
| --- | ||
|
|
||
| # Customize built-in policies | ||
| # Customize built-in {{ilm-init}} policies for {{agent}} data streams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stated scope conflicts a little with some of the xrefs. this one just says agent data streams, but we also have the following scopes indicated on the other pages you edited:
- {{beats}}, {{agent}}, or for the {{agent}} or {{ls}} {{es}} output plugin managed data streams
- Elastic integration managed data streams
maybe this should become managed data streams and the fleet info on this page might pivot to a "for example" framing
accuracy on all of this I'm not certain on - just looking at signals I'm seeing within this doc :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth doing a dive to find the context in which those two contexts were added to clarify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Seems like the title describes well the use case in the tutorial, but doesn't account for use cases mentioned in the topics that link to it.
I'll find someone to validate this with and make some changes.
|
Hi @rseldner -- as discussed on Slack, I've changed the title of the Customize built-in policies to Customize duplicates of built-in ILM policies -- to avoid implying that we're modifying built-in policies, which goes against best practice advice. I've also made a few small changes in the topics that link to this tutorial, to better clarify the scope of the tutorial. Please let me know if you think that works. Many thanks in advance! 🙏 |
manage-data/lifecycle/index-lifecycle-management/tutorial-customize-built-in-policies.md
Show resolved
Hide resolved
…difying other policy duplicates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
manage-data/lifecycle/index-lifecycle-management/manage-lifecycle-integrations-data.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🌵
Just one small suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Should we add a note at the end of tutorial-customize-built-in-policies.md that the changes will apply to the new indices and a rollover can optionally be triggered to begin using immediately?
…using the new policy immediately
|
Thanks, Roberto!
That's a great shout! I've added that in a new commit. |
Fixes #3285 to clarify that the scope of the tutorial refers to Elastic Agent data streams that use built-in ILM policies.